Make ClearColorConfig::None work correctly (esp in the presence of MSAA)#23844
Merged
alice-i-cecile merged 7 commits intobevyengine:mainfrom Apr 17, 2026
Merged
Make ClearColorConfig::None work correctly (esp in the presence of MSAA)#23844alice-i-cecile merged 7 commits intobevyengine:mainfrom
ClearColorConfig::None work correctly (esp in the presence of MSAA)#23844alice-i-cecile merged 7 commits intobevyengine:mainfrom
Conversation
tychedelia
added
C-Bug
Member
Author
|
@beicause Some more here about MSAA writeback, I know you've had opinions here before. |
beicause
reviewed
Apr 17, 2026
Comment on lines
+1245
to
+1254
| // re-use the same atomics frame to frame for views with the same main texture | ||
| // to ensure post process writes persist through msaa writeback | ||
| let main_texture = main_texture_atomics | ||
| .get(&key) | ||
| .and_then(Weak::upgrade) | ||
| .unwrap_or_else(|| { | ||
| let arc = Arc::new(AtomicUsize::new(0)); | ||
| main_texture_atomics.insert(key.clone(), Arc::downgrade(&arc)); | ||
| arc | ||
| }); |
Member
There was a problem hiding this comment.
Can use HashMap.entry
Is it correct to use Weak<AtomicUsize>, won’t it be dropped at the start of each frame?
Member
Author
There was a problem hiding this comment.
Basically, we re-insert the ViewTarget every frame. As long as the configuration doesn't change, this is just replacing the effective same component over and over again. So there is an existing strong handle on the component, which we will replace here. I forgot to add the clean-up at the top of the system, but it's basically a cheap way to see if an entry is actually being used. I also just switched to using the actual entry api here, thanks!
HackerFoo
approved these changes
Apr 17, 2026
alice-i-cecile
approved these changes
Apr 17, 2026
alice-i-cecile
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two separate issues:
Loadsemantics on their camera and MSAA is enabled, otherwise we'll throw away the main target texture incorrectly.